We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
Loading...
  1. Practice
  2. Algorithms
  3. Implementation
  4. Between Two Sets
  5. Discussions

Between Two Sets

  • azicon + 2 comments

    100*99*97*91*89*83*79*73*71*67~1.7*1e19, so if b = {100, 99, 97, 91, 89, 83, 79, 73, 71, 67} lcm(b) be over integer range

    • ishita_ghosh + 2 comments

      for this case, why is lcm coming negative?

      • azicon + 1 comment

        because lcm(b)~1.77*10^19, which is out of integer range, even long long range. So integer overflow happens (https://en.wikipedia.org/wiki/Integer_overflow) // integer range is from -2^31 to 2^31-1~2.15*10^9, long long range is from -2^61 to 2^61-1~3.21*10^18.

        • ishita_ghosh + 1 comment

          Yes i have understood. But how can we proceed with program when our lcm is coming to be negative. Shouldnt the program logic give wrong results then?

          • azicon + 2 comments

            I've noticed hackerRank has poor tests. That is why such solutions pass tests. Specifically in this task variable l can not be greater than 100. So I recommend you return 101, when result variable from lcm fuction is coming greater than 100. It will prevent for loop which count "count" variable So sorry for my poor english, it is not my native language

            • ishita_ghosh + 1 comment

              ty

              • azicon + 0 comments

                you are welcome

            • bitralahari20171 + 0 comments

              yeah i too feel that hkrnk has poor tstcases

      • alaniane + 0 comments

        When you overflow an integer, it will wrap around. At the assembly level you can check to see the zero and overflow flags have been set. So an overflow on a signed int can set the bit that indicates that the number is negative.

    • ikeka95 + 0 comments

      It should not go out of range. Use { function lcm(arr){ var multiples = {}, factors, f = [], lcm = 1;

      for(var i of arr){
    factors = primes(i);
    f = [];
    for(var factor of factors){
        if(f.indexOf(factor) == -1){
            f.push(factor);
            if(typeof multiples[factor] == 'undefined'){
                multiples[factor] = countElement(factors, factor);
            }else{
                multiples[factor] = Math.max(multiples[factor], countElement(factors, factor));
            }
        }
    }
}

for(var i in multiples){
    lcm *= i ** multiples[i] ;
}
return lcm;

      }

      function primes(number) { number = Math.abs(number); var divider = 2, dividend, factors = [];

      while(number != 1){
    dividend = number/divider;
    if (dividend.toString().indexOf('.') != -1) {
        divider++
        continue;
    }
    number = dividend;

    factors.push(divider);        
}

return factors;

      }

      function countElement(haystack, needle) { var count = 0; for(var i of haystack){ if(JSON.stringify(i) == JSON.stringify(needle)) count++; } return count; } }