We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
While this works, you loop through the complete collection of values 3 times. First while reading it in the scanner. Second while scanning for the max value in the collection after reading it in and third to count the number of times it was found.
I'm not too familiar with the BigO notation, so an honest question how does it become n+n+n shouldn't it be 3n rather as you are doing full loops over all elements?
In some test cases, the highest (max) element is the one most common - like in example case, where 3 is the most common element. It also passes some test cases.
The correct solution is the one with Counter.
My solution finishd in about half the time, I would assume because I'm looping through it only once. Depends on whether you want a quick and dirty solution (mine) or one that's more Pythonic (in your case, can be more difficult to read):
data=[10,3,333,333,333,0,13]tmp=data[0]#max datatmp2=0#max data counterforiinrange(len(data)-1):forjinrange(i+1,len(data)):if(tmp<=data[j]):tmp=data[j]forkinrange(len(data)):if(data[k]==tmp):tmp2+=1print(tmp2)
this was my code.
to get max_height, i use the loop twice. so it didn't work.
but like you said, its working with single loop! thanks
and it is so amazing that you used single looop... never imagined it
I use max function in list. 7 out of 8 test cases work. I am not sure what's wrong with my code. Can you please have a look ?
n1=input().strip()# Input age valueb1=input().strip().split()# Input list of candle heightsdefbirthdayCakeCandles(n,b):c=0z=max(b)foriinb:ifi==z:c+=1return(c)y=birthdayCakeCandles(n1,b1)print(y)
EDIT: My mistake, i've missread the description :(. So the rest of the comment is invalid.
This doesn't work. It only counts how many times the highest element from the list (max(arr)) is in the list. In some test cases it works. In some it doesn't -> it's not a correct solution
Hi I also use the same way to count in Python print(arr.count(max(arr))), but the result is always 2, none, which show me the worng answer. I do not know why it show me (2, none) instead of just 2.
Birthday Cake Candles
You are viewing a single comment's thread. Return to all comments →
Counting the tallest candles.
python is the best!
Any problem with Java @abhishek106
While this works, you loop through the complete collection of values 3 times. First while reading it in the scanner. Second while scanning for the max value in the collection after reading it in and third to count the number of times it was found.
anyway the time complexity is O(n+n+n) = O(n)
I'm not too familiar with the BigO notation, so an honest question how does it become n+n+n shouldn't it be 3n rather as you are doing full loops over all elements?
In BigOh notation, I believe they drop the constants in front of n because exponents matter so much more that the constants are negligible.
Why do that instead of just?
Wow, egrodo1, Python for the win!
I basically did the same thing!
nice code! as I am a beginner, I think very long and messy code.... lol
Map object doesn't have the count attribute. You will get an error
Thank you! I hadn't realized Python had a count method for lists that basically reduces the problem to 1 step.
what is the code of "count" function?? bcos when I am using loop instead of count fuction, its taking too much time to run. pls help??
I am using loop but it is the same thing with ar.count(max(ar))
Exactly like I did! Nice!
This is not a correct solution but I do not know why it is passing. You should:
In some test cases, the highest (max) element is the one most common - like in example case, where 3 is the most common element. It also passes some test cases. The correct solution is the one with Counter.
just simple
actually :-)
Why is there a [0][1]?
My solution finishd in about half the time, I would assume because I'm looping through it only once. Depends on whether you want a quick and dirty solution (mine) or one that's more Pythonic (in your case, can be more difficult to read):
this was my code. to get max_height, i use the loop twice. so it didn't work. but like you said, its working with single loop! thanks and it is so amazing that you used single looop... never imagined it
I use max function in list. 7 out of 8 test cases work. I am not sure what's wrong with my code. Can you please have a look ?
similar:
EDIT: My mistake, i've missread the description :(. So the rest of the comment is invalid.
This doesn't work. It only counts how many times the highest element from the list (max(arr)) is in the list. In some test cases it works. In some it doesn't -> it's not a correct solution
i don't understand. it's what we are looking for, is it not?? ;)
You're right, I've missread the description.
Hi I also use the same way to count in Python print(arr.count(max(arr))), but the result is always 2, none, which show me the worng answer. I do not know why it show me (2, none) instead of just 2.
Try to return the value from the function instead of printing.
python FTW:>