We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
just an optimization, even though in this case your code is fine:
if you try an array with negatives, then you ll never get inside your if-statements. so the numMaxHeight will never change, so you dont really compute it in such cases.
so this solution for an array with negatives, where the max negative appears more than once, will fail. eg [-1, -1]
proposed solution: set numMaxHeight = 0 on initialization
if you use quicksort u already have O(nlogn) which is worse than just iteratring through the array and saving the highest value and then just iterate a second time incrementing a counter everytime the value is similar to the saaved one. then complexity is O(2n) = O(n).
With n = 100 you would have ~ 600 steps(n*logn = 100 * 6 = 600) with your solution and just 200 steps with mine
Did you try using c++ std::sort(ar.begin(), ar.end()); ? I did and it worked flawlessly.
int birthdayCakeCandles(int n, vector<int> ar) {
// Complete this function
sort(ar.begin(), ar.end());
int max = ar[ar.size() -1];
int count = 0;
for(auto num : ar) {
if(num == max) ++count;
}
return count;
Birthday Cake Candles
You are viewing a single comment's thread. Return to all comments →
this code was working on some test case but not all please help me
/*You should do like this... */
In java, maybe this way can help you! :)
just an optimization, even though in this case your code is fine: if you try an array with negatives, then you ll never get inside your if-statements. so the numMaxHeight will never change, so you dont really compute it in such cases. so this solution for an array with negatives, where the max negative appears more than once, will fail. eg [-1, -1]
proposed solution: set numMaxHeight = 0 on initialization
You can simplify it like this:
int max=ar[0]; int count=0; for(int i=0;imax){ max=ar[i]; count = 1; //Reinitialize count if you found a new max }
} return count;
I this case you are traversing the vector only once.
i did the same thing.But it is showing me 4 test cases failed.
Be aware of time complexity. In my testcase 4, n was 10000. If you use a sorting algorithm with n^2, you will get a runtime error.
The way I structured my code is:
I tried this
It is failing the test case
100000 followed by 100000 times 9999999 (as height of candles(array values)).
Pass all Testcases..
Try This
static int birthdayCakeCandles(int[] ar) {
need to add one more check in while condition for all the array elements with same value
while ( i > -1 && a[i--] == tallest ) { count++; }
if you use quicksort u already have O(nlogn) which is worse than just iteratring through the array and saving the highest value and then just iterate a second time incrementing a counter everytime the value is similar to the saaved one. then complexity is O(2n) = O(n). With n = 100 you would have ~ 600 steps(n*logn = 100 * 6 = 600) with your solution and just 200 steps with mine
}
ar[i]-max==0 in second if worked for me
sandeep did u use unsigned long or any other data type which allows you to take in large amounts of data?