Michael123 no need to read the input as string . read it as int using "scanf("%1d",your array[i)[j]);" ...read only a single digit at a time
Hitesh_Parmar Thanks a lot...Your solution helped
Michael123 You're welcome
callmesahil21 Thanks man it helped.
Michael123 Your're Welcome
H1996 Thanks
Michael123 You're Welcome
shivam_merothiya thanx alot
_Radix_ Can you do it in C++ without using C commands?
saksham1999 Using C++
int main(){ int n; cin >> n; vector grid(n); for(int i = 0; i < n; i++){ cin >> grid[i]; } std::string::iterator it,jt1,jt2; int c=0; char temp; for(int i = 1; i < n-1; i++) { c=0; int d=0,e=0; for (it=grid[i].begin(); it!=grid[i].end(); it++) { c++; if(c>1 && c*jt1) {
for(jt2=grid[i+1].begin(); jt2!=grid[i+1].end(); jt2++) { e++; if(e==c) { if(temp>*jt2) temp='X'; } } } } } } *it=temp; } } } for(int i = 0; i < n; i++) cout<< grid[i]<<endl; return 0;}
thevkc vector <string> cavityMap(vector <string> arr) { int n = arr.size() ; for(int i = 1 ; i < n-1 ; i++) //ignoring first and last rows { for(int j = 1 ; j < n-1 ; j++) //ignoring first and last columns { if( arr[i][j]-48 > arr[i-1][j]-48 && arr[i][j]-48 > arr[i+1][j]-48 && arr[i][j]-48 > arr[i][j-1]-48 && arr[i][j]-48 > arr[i][j+1]-48) arr[i][j] = 'X'; } } return arr ; }
yashu191298 you cant replace it during the check.
abhishekrajput41 [deleted]
akshaykumsharma not need to put 48 in comparison
meaditi Why u substracted with 48???
viigihabe https://stackoverflow.com/questions/439573/how-to-convert-a-single-char-into-an-int There is a comment in top answer that states that -48 woun't work on every encoding. There is another aspect - your question. Would you have a question if the code was: arr[i][j] - '0' ...? Probably not. In my opinion the use of -48 falls into bad practice. And note: because both operands are subtracted the subtraction itself is obsolete.
h160040582 he has taken the array as string and so for comparing numbers he subtracted the array with ascii value of number '0' i.e. 48 which will give the number directly during comparison.
richa_rao1 Why not include first and last row and column?
nitinshaily0 since they are at end or perifery of grid and it is specify in the problem that they must be excluded
tushar_dsr Why this is not working? I did the same.
andreyv_moshes Don't subtract by
'0'without documented need like a string to int parser. If you want to assume that'X'>'9', useassert('X'>'9')at the top of the function.tushar_dsr yupp I got it
Mandeep31 That works, but it's easier to do using string (or char array) because you can easily assign a cell to 'X' if it's a cavity, which would be a better approach (in my opinion). Moreover, comparing characters works fine as well since ascii value '9' > '8' > '7' > ...
learningprakash for scanning use int and For Placing X put it in string row grid[]
omkar8kadam how to store X in int array
phoenixRises You can't. What you can do is, do the comparisons and output at the same time, so when you find a cavity, output an X instead of the digit. While you could have read the input as characters and compared and assigned the X, using integers is generally easier to understand, so I would prefer reading the input as integer. But if you want to stick to keeping the processing and output separate, use a 2D character array.
lakshmikantd Why would one store X if you can store a sentinel value(say Integer.MAX_INT), and print X while printing, when a sentinel is encountered
rvrishav7 make it string array
sharadsingh I suggest you to change the number when their is any cavity to any negative number (let us change cavity a[i][j] to value -1) and then while printing you print the value 'X' in place of that negative number.
ennorehling There's also no need to interpret the input as digits. '9' is strictly larger than '8' as well, etc.
archit_agrawal31 how do i print the array
lakshmikantd for loops will exclude all elements at the edge (Only - elements in the following diagram)
+++++ +---+ +---+ +---+ +++++
check all the inner elements' left, right, upper and lower elements. If these elements are smaller than the center element, change it to Integer.MAX_INT.
While printing, simply print X if Integer.MAX_INT is encountered. ;)
positivedeist_07 Same I did, but instead of assigning MAX_INT, I assigned -1. Not working :(
lakshmikantd Let's consider a test case
let the original matrix be
1 1 1 1 1 5 4 1 1 1 1 1 1 1 1 1
In this case, your program will mark 5 to -1, as all the surrounding elements are smaller than 5.
1 1 1 1 1 -1 4 1 1 1 1 1 1 1 1 1
But now in the next iteration for 4, all the surrounding elements (including -1) are smaller than 4, so it will mark 4 as -1 as well.
it will print output as
1 1 1 1 1 x x 1 1 1 1 1 1 1 1 1
But it should have printed
1 1 1 1 1 x 1 1 1 1 1 1 1 1 1 1
I faced the same problem. So I changed -1 to Integer.MAX_INT.
Let me know if you need more help. All the best.
yashp241195 You saved my life bro :)
Power_Of_Chi The output will be .... right?
1 1 1 1 1 x 4 1 1 1 1 1 1 1 1 1
prakhar123mishra i am not able to understand question, can anyone please explain me the question in easy language. a no. whose left and right adjcent is small, so the no should replaced with "x". anyhting else
tushar_dsr the tile you want to observe, then all the four tiles sharing boundary you need to see.
archit_agrawal31 how do i print the array
charan_sai [deleted]leech932 If you're dong this in C there's no point in doing the ascii to number conversion, use scanf(" %c",&array[x][y]);
You can take advantage of the fact that ascii 'X' > ascii'9' > ascii '1' and just compare the chars directly.
viigihabe Basically there is no need to convert them in any language, since comparison of characters leads to same conclusion. Any language will consider "12" > "13" as falsy. And "9" > "8" as truthy.
edrouwendaal C# read as string
static string[] cavityMap(string[] grid) { for (int i = 1; i < grid.Length - 1; i++) { for (int j = 1; j < grid[i].Length - 1; j++) { int middleUpper = (int)char.GetNumericValue(grid[i - 1][j]); int left = (int)char.GetNumericValue(grid[i][j - 1]); int right = (int)char.GetNumericValue(grid[i][j + 1]); int middleUnder = (int)char.GetNumericValue(grid[i + 1][j]); var adjacent = new int[4] { middleUpper, left, right, middleUnder }; if (adjacent.Any(a => a < 0)) continue;//smaller than 0 if X in adjacent cell int ij = (int)char.GetNumericValue(grid[i][j]); if (adjacent.All(a => a < ij))//Can use StringBuilder instead(faster?) grid[i] = grid[i].Remove(j, 1).Insert(j, "X"); } } return grid; }
sduhigg Nice.
I got hung up on the replacing the X part, almost had it, just didn't have the remove before the insert.
kris_tobiasson Here is a pretty simple JS version:
for(let i = 1; i < grid.length-1; i++){ let nums = grid[i].split(``); for(let j = 1; j < nums.length-1; j++){ if(nums[j] > grid[i-1].charAt(j) && nums[j] > nums[j+1] && nums[j] > grid[i+1].charAt(j) && nums[j] > nums[j-1]) { nums[j] = `X`; } } grid[i] = nums.join(``); } return grid;
ahmad1_adnan95 thanx a lot bro... please keep posting such answers
mridul27gupta I have done the same thing in java but my few test cases are showing incorrect. Please help here is the code:
static String[] cavityMap(String[] grid) { for(int i = 1; i < grid[0].length() - 1; i++) { for(int j = 1; j < grid[0].length() - 1; j++) { if(Character.getNumericValue(grid[i].charAt(j)) > Character.getNumericValue(grid[i].charAt(j-1)) && Character.getNumericValue(grid[i].charAt(j)) > Character.getNumericValue(grid[i].charAt(j+1)) && Character.getNumericValue(grid[i].charAt(j)) > Character.getNumericValue(grid[i - 1].charAt(j)) && Character.getNumericValue(grid[i].charAt(j)) > Character.getNumericValue(grid[i + 1].charAt(j))) { grid[i] = grid[i].replace(grid[i].charAt(j), 'X');
} } } return grid; }1rn18cs056_mahi1 EVEN I USED THE SAME LOGIC!NOT WORKING:((
harshchaplot11 Thanks man!!! I was confused how to take the input
hrshtvrm For the Java people wondering how to accept the String matrix, here is a way,
` char c[][]=new char[n][n]; String s[]=new String[n];
for(int i=0;i<n;i++){ s[i]=sc.next(); } for(int i=0;i<n;i++){ int k=0; for(int j=0;j<n;j++){ c[i][j]=s[i].charAt(k); k++; }}kumar_ak16121999 thanks a lot man i have just wasted more than 1 hr and i was not able to figure out my mistake.
rajat020730 thanksssss man you saved me a whole lot of time
sayantanmaiti Why does Test Case #2 have spaces in the input grid? Although submitting the code that works for the Test Case #1 (one without the spaces) works fine for everything else, and gives the full 30 points,
I kind-of wasted my time because my code was reading the spaces in the grid rather than the number itself.
turkerunlu I also had the same issue, there is also the same issue in one of test cases when you submit but I still got full points even though that case failed.
cheesus the conditions are:
1) is right or left of the current value a value that is greater or equals
2) is above or below of the current value a value that is greater or equals
3) is it in the first or last row or is it the first or last number
if so it cant be a cavity
I just created an inverse of a 2 dimensional array and checked those conditions for both matrices. Even its O(N*N) it doesnt needs a 1/10 of a second
thanhbinh84 strictly smaller depth
->
1) is right or left of the current value a value that is greater or equals
2) is above or below of the current value a value that is greater or equals
Should be
1) is right or left of the current value a value that is greater
2) is above or below of the current value a value that is greater
ashish09712 Conditions: right,left,top,down < center
RoshithS helpful. i ws nt getting the scenario exactly
theoriginscode13 Thanks brother you saved my time. Initially I just took for the adjacent ones in the row only.
rohit1007raj Same here buddy. Thanks for this thread.
selftaught91 Read your input as string and not as integers then the problem can be solved
ajayu2bono Thanks that was my mistake
devs_338374 if i take input as string the how will you print the numbers inside it
PRASHANTB1984 you need to use the equivalent of Java's Big Integer after processing the string and parsing it into numbers. Or, in languages like Ruby and Python, you don't need to do anything special to handle very large numbers, much of the time.
harshulgandhi Do we really need to parse it into numbers. We can simply take Char 2D array and input each integer as a string. Then divide this string into individual characters (there are multiple ways of doing that). Comparison also works fine if we keep it to char array because ascii value of (char) '9' > '8' > '7' ...'2' > '1'
Moghaak I tried this one in CPP my code reduced from 75+ lines to 25 lines.
Thanks.
khalludi123 Not always. You can still read it as numbers. I used Java's BigInteger.
thejay10125 [deleted]Omnikron13 What is the point though? It ISN'T an integer, it is a string of integers...
mlobosco I ended up using BigInteger as well and it ended up being relatively simple. The difficult part was keeping track of the Int/BigInteger operations.
rsb33 thnX..
Gautham_B_A Use Python. You don't have to worry about the type. :P
roryneil Ha! So true. I converted the ints to strings to convert them into lists, and solved the problem. I never noticed that I never converted each char in the array back to an int for comparison, but everything worked! Plus, I saw something about 75 lines above?
amazing_naina How did you mutate the str object?
akashshetty08 [deleted]akashshetty08 [deleted]akashshetty08 n = int(input())
a = []
for i in range(n):
a.append(list(input()))for i in range(1,n-1):
for j in range(1,n-1): if a[i][j] > a[i+1][j] and a[i][j] > a[i-1][j] and a[i][j] > a[i][j+1] and a[i][j] > a[i][j+1]: a[i][j]="X"for i in range(n):
print("".join(str(x) for x in a[i]))Can you tell me what the error is?
AffineStructure you can make your code more readable if you stack the if statement like this
for j in range(1,n-1): if (a[i][j] > a[i+1][j] and a[i][j] > a[i-1][j] and a[i][j] > a[i][j+1] and a[i][j] > a[i][j-1]): a[i][j]="X"
I also fixed the error in the code. the for loop in your code had j+1 for both the first and second check.
singhravinder111 [deleted]singhravinder111 how to add comment like a code
pbppiyush grid[i][j]>=grid[i-1][j-1] && grid[i][j]>=grid[i-1][j] && grid[i][j]>=grid[i-1][j+1] && grid[i][j]>=grid[i][j-1] && grid[i][j]>=grid[i][j+1] && grid[i][j]>=grid[i+1][j-1] && grid[i][j]>=grid[i+1][j] && grid[i][j]>=grid[i+1][j+1]
maitrayan6p how can you compare str values? You first have to convert in into string then you can compare the values
murali_111 You replace the element with 'X' while iterating, and again whn you are checking the previous element with [j-1] , if it is 'X' it will check if your element is greater than 'X'., so you should check if your [j-1] or [i-1] is 'X' or not. Just add this to your if statement.
mike_buttery Python can evaluate strings including numbers and letters
>>> '0'<'1'<'2'<'3'<'4'<'5'<'6'<'7'<'8'<'9'<'X' True
As you iterate through the grid the cavities are marked with the
'X'where all the adjacent cells are less than. For example1111 1911 1911 1111
returns with no cavities as
9and9are equal.If we replace with an
Xit is because the surrounding cells evaluate as less than.So if
9 > 8so too isX > 8so the relationship between the cells is maintained and there is no need to check forX
Devicharith how does line 3 and 4 work in python??
peacefulbaba10 I'm trying a similar this but the compiler is throwing an error as "list index out of range"
_CAAI Instead of using two arrays, compare the center matrix (formed excluding boundary values) while printing the matrix..! ;)
int n,i,j; scanf("%d",&n); int a[n][n]; for(i=0;i<n;i++) { for(j=0;j<n;j++) { scanf("%1d",&a[i][j]); } } for(i=0;i<n;i++) { for(j=0;j<n;j++) { if( (i>=1)&&(i<n-1) && (j>=1)&&(j<n-1) ) { if( (a[i][j] > a[i-1][j]) && (a[i][j] > a[i][j+1]) && (a[i][j] > a[i+1][j]) && (a[i][j] > a[i][j-1]) ) printf("X"); else printf("%d",a[i][j]); } else printf("%d",a[i][j]); } printf("\n"); }
inkhl Thanks!
SushmaN if we replace %1d with %d... why the input contains extra zeros?? what is the significance of 1? can you please explain..
phoenixRises %1d signifies read 1 digit at a time. If you write %d, one entire row of digits will be read at once, which is not what you want.
patomack Nifty!
priyank042 yeah..!! Thanks.....
amanakmsd Thanks! Very helpful
sb2098 coool!
160216733001_cs nice
ME_170070246 thank you for the code
psatishkumar720 [deleted]hardikkamboj1 I had also gone with the same logic..but the problem is that some test cases contain spaces whereas some test cases don't have spaces.. Please help me on that..
zalak_delvadiya Same problem....... Any solution?????
frankdeadlycaste def cavityMap(grid): M = grid N = len(M)
for i in range(N): for j in range(N): if not ( i in [0,N-1] or j in [0,N-1] ): c = M[i][j] if M[i-1][j] < c and M[i+1][j] < c and M[i][j-1] < c and M[i][j+1] < c : temp = M[i] temp = list(temp) temp[j] = 'X' temp2='' for j in temp: temp2+=j M[i] = temp2 return M
Sort 513 Discussions, By:
Please Login in order to post a comment