We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
Loading...
  1. Practice
  2. Algorithms
  3. Implementation
  4. Extra Long Factorials
  5. Discussions

Extra Long Factorials

  • xinchen112 + 4 comments

    hello, I use java and try to solve it using a recursive method

    public static void main(String[] args) {
        // TODO code application logic here
       Scanner in = new Scanner(System.in);
        int N = in.nextInt();
        System.out.println(factorial(N));
    }
public static long factorial(int n){
        if(n<0) 
            return -1;
        else if(n==0) 
            return 1;   
            else 
            return (long) n*factorial(n-1);
    }

    the result is not correct, but I can't find the reason. Please help.

    • cesaregb + 1 comment

      withouth trying the code, I notice that you are using "long" vars, the problem mention that some of the number cannot be stored in a long (ie 64 bit type). Probably with a BigInteger can work.

      • xinchen112 + 0 comments

        Yes,you are right! Thank you!

    • jkamyabi + 0 comments

      Obviously it's a recursive solution, but the problem is much bigger than it. You have to calculate factorial using manually implemented data types.

    • Oarr2 + 0 comments

      it only works with n=1,2,....,19. The statement asks you to calculate 0<=n<=100. with a big n the answer of your code is negative because it overflows.

    • psprachi955 + 0 comments
      [deleted]