rafa26 would be brutal for the user if he submits book on jan 1st and expected retun date was 31st dec. 10,000 hackos though should be 15 hackos because technically book is 1 day late.
shashank21jHackerRank Admin Yes that would be unfortunate.
pcristea Maybe you should edit the question to have it actually make sense. This problem is flawed and doesn't make sense in the real world.
Fazil_Pasha That's true, but I think the question only needed you to come up with straight forward equations for the four statements.
singhashutosh Exactly!
paulclift Doesn't really matter if the rules are flawed, programmers just follow them.
AllisonP The point is to take the problem and find the most concise way to layer conditional logic. That's why this problem is in the "warmup" section.
aditya149 this is in implementation section.
AllisonP The challenge was moved to another subdomain section after I wrote that comment.
VJATIN https://www.hackerrank.com/challenges/library-fine/copy-from/34717423 what is wrong in my logic and how we can think to correct the logic and how we can optimize this code please explain in better manner 5,10,16 test case of this ques does not pass?why?give reason
itsrohan Have you found the correct solution yet? facing the exact same situation
VJATIN i will not found soln till now if i found soln then i will help you
FilipF Test your code for some input like:
01 12 2017 01 01 2018
The actual date is a month before the expected date, so the fine should be zero.
naathiparamesh11 case 10 also same like this 28 2 2015 15 4 2015 Actually the book was returned before expectedd date so output should be 0 right
aloksingh3007 Thanks ! It helped
FilipF Test your code for some input like:
01 12 2017 01 01 2018
The actual date is a month before the expected date, so the fine should be zero.
acc_surajtripat1 an year before :)
yfadeev Should not the expected output for the input like this be
1000instead of1500as it does not represent 3 full months?5 5 2014 23 2 2014
Ideally, it should consider the library's fee for 2months and 13 days
gabe2390 I thought i was the only one for a second. I came up with 15, but the testcase output says 10000.
sagar_code [deleted]
vbalayan altough logically that makes sence, point of this task is testing if programmer knows how to handle DateTime api... I'd suggest not to change anything :)
pavneet_singh yeah man 14th case has such a poor prediction as output .i hope vatsalchanana will sue any student by his liabrary fine calculation logic
chakravarty_k Yes, I think the answer is wrong. It should be 15 hackos.
Gawar [deleted]Gawar Make sure Hackerrank team does not open a library.
heyheyehey That's what you get for trying to spend time with your family.
carlos_bucheli_1 I agree, actually if we use date functions or api's the result will be 1 day but the test marks that as failed, that's unfortunate for us as participants because the test actually doesn't reflect that we indeed use date functions/api's well enough.
shashank21jHackerRank Admin yes that APi use is discouraged. It's a challenege testing conditional loic.
vs97849 haha! lol
jimmycanosa I will not happen though. Most probably the librarian celebrating a holiday and the library is close. Hahahahaha
saviour I think the fifth and tenth cases are screwed up. Please check. All else I got correct answers. Here's my solution: https://www.hackerrank.com/challenges/library-fine/submissions/code/12064663
5th case: Input: 2 7 1014 1 1 1015 Output: 0 As expected, returned before expected date
10th case: Input: 28 2 2015 15 4 2015 Output: 0 Again, as expected
PhilipeNelson I had problems with the same tests you had, but I actually found an error in my logic. Once fixed, it passed all tests. Try to review your code and check your tests. Maybe you forgot to output data in some specific scenario.
saviour I spent 10 hackos, got both the test cases, checked I/O. So I'm sure that the output is in expected format and correct.
bhargavaaman1995 I am having the same problem
Paritybit As am I...Anyone have any luck?
dexstakker Check your assumptions about return dates.
hashimshafiq0 [deleted]saidbbosov ok i soglasyen do you speak russian
roydor Specifically if it was returned in an earlier year than the due date's year, but in a later month than the due date's month.
Due:May 3, 1985
Returned:March 2, 1984
Be careful you're not returning 30 here (may - march) * 15.
Supbads They are correct, I just fixed my logic and it went well. " else if (m2 < m1) { if(y2 > y1) { Console.WriteLine(0); return; } .... " in the month condition
"else if (d2 < d1) {
if(y2 > y1 || m2 > m1) { Console.WriteLine(0); return; } ... "in the days condition
ashishgoyanka i passed all test cases..so test cases do not have any problem you can comment your code then we will review on that
metison123 import java.io.; import java.util.; import java.text.; import java.math.; import java.util.regex.*;
public class Solution {
public static void main(String[] args) { Scanner in = new Scanner(System.in); int d1 = in.nextInt(); int m1 = in.nextInt(); int y1 = in.nextInt(); int d2 = in.nextInt(); int m2 = in.nextInt(); int y2 = in.nextInt(); int fine; if(y2 == y1 || y1 < y2){ if(m2 == m1 || m1 < m2){ if(d2 == d1 || d1 < d2){ fine = 0; } else fine = (d1 - d2) * 15; } else fine = (m1 - m2) * 500; } else fine = 10000; System.out.println(fine); }}
[deleted] This one, in Python, flows smoothly in all the test cases:
def libraryFine(d1, m1, y1, d2, m2, y2): fine = 0 if y1>y2: fine = 10000 elif y1<=y2: if m1>m2 and (y1>=y2): fine = 500 * (m1-m2) elif m1<=m2: if (d1>d2 and (m1-m2>=0) and (y1>=y2)): fine = 15*(d1-d2) else: fine = 0 return fine
michal_remis I thing your conditions are too complicated.. e.g. you check both y1<=y2 and y2<=y1.. why not just check y1==y2 ? Same with m1,m2
tat_lim @michal_remis Agreed!
def libraryFine(d1, m1, y1, d2, m2, y2): if y1>y2: return 10000 if y1==y2: if m1>m2: return (m1-m2)*500 if m1==m2 and d1>d2: return (d1-d2)*15 return 0
tbholdren I ended up doing the exact same thing, except my method starts with a 'fine' variable equal to zero, and it gets set under the different conditions. Default is to return no fine. I'm not a big fan of multiple returns in a single funciton.
programaths You can avoid all the "else" by bailing out. The statement that one should avoid multiple "return" do not always hold true and is not alway wize.
Here is an axample:
def libraryFine(d1, m1, y1, d2, m2, y2): if y1<y2: return 0 if y1>y2: return 100000 if m1<m2: return 0 if m1>m2: return (m1-m2)*500 return (d1-d2)*15
We are "pruning" the possibilities from top to bottom. First we deal with years. If it's the year before, we know it is 0 and there is nothing more to do. If it's the year after, we know it is 100000 and there is nothing more to do.
Then we have to deal with months only. Same story, but now we have a formula to calculate the fine.
When we dealt with month, we only to take care of days.
As you can see, more we go down, less we have to remember! The programe flow and state becomes easier as we go deeper because we prune variables!
If you look at your program, you got confuse and wrote unnecessary conditions and even made them very complex.
Early return and bail out are very powerfull tools. Usually, it's in the shape:
some_code if condition: return bailout_value more_code
The code I wrote is an extreme example of it. Mind the blank lines which provide extra information!
tat_lim @programaths Agreed!
def libraryFine(d1, m1, y1, d2, m2, y2): if y1>y2: return 10000 if y1==y2: if m1>m2: return (m1-m2)*500 if m1==m2 and d1>d2: return (d1-d2)*15 return 0
madhavarapurao71 include this sattement also at last ,with mentioned code avove 4test case does not excutes Coder.. if (y1 < y2) { fine = 0; }
shashank21jHackerRank Admin What is your point? http://inft.ly/48jeZKF
saviour All this while I thought that the output I see when I spend the hackos was my program's output. Thanks to a friend I realized now that, that is the correct output. Really sorry. BTW found the bug :D
mayank_sharma_e1 [deleted]itseasy This may be the most helpful comment ever. ;)
gautam0707 do we need to consider leap year..number of days in a months..and so on...
shashank21jHackerRank Admin nopes
afroze100 These details should have been mentioned in the actual questions.... Laziness doesn't get you anywhere!
Fazil_Pasha Over complicating things doesn't get us anywhere either. The question needed you to just follow the four statements.
TheRealist [deleted]
gengokoukan1 I also initially had problems w/ those 2 test cases, found bugs in my logic, and now all tests pass. So, at least as of this time, there are no bugs in the tests ;)
IRIDIUM Exactly
btapkan I still have the problem ...
dexstakker @mtapkan: With test cases 5 and 10 specifically?
hashimshafiq0 Same problem test case 5th and test case 10th screwed. :(
RryLee yeah
julio_ahuactzin [deleted]
AllisonP Those cases make logical sense, as both of the actual return dates occur before the expected return dates. I can't see your solution, but it sounds like there is a problem with the way you're nesting your conditional logic. You should be checking the year, then the month within the year, then the day within the month.
hashimshafiq0 Thank you for ur help @Allison :) I figured out my mistake already thanks alot. :)
BullKnows Thanks for sharing your info for solving the problem. It finally helped me locate my bad logic.
metison123 same.... checked in custom input, and got the answer correct, but fails in submission....
udith7 true same problem
Ninja_kx [deleted][deleted] I tried, after several I/O, the following code, which showed no errors:
def libraryFine(d1, m1, y1, d2, m2, y2): fine = 0 if y1>y2: fine = 10000 elif y1<=y2: if m1>m2 and (y1>=y2): fine = 500 * (m1-m2) elif m1<=m2: if (d1>d2 and (m1-m2>=0) and (y1>=y2)): fine = 15*(d1-d2) else: fine = 0 return fine
heySourabh Here is my Java code, writing a separate method for fine() actually simplifies the logic due to return statements.
public static int fine(int da, int ma, int ya, int de, int me, int ye) { if(ye < ya) return 10000; if(ye > ya) return 0; if(me < ma) return 500 * (ma - me); if(me > ma) return 0; if(de < da) return 15 * (da - de); return 0; }
ShivaSekar93 how did this alone working? when ordinary conditional statements failed. please explain?
hydeenoble I dont think this should work
heySourabh This works because of the return statements. In case of if-else blocks we have to add more else-blocks just to ensure that the conditions below are not executed. Due to return statement the control is passed back to the calling method instantly.
I thought of this logic as if a person sitting and making the decisions. The person looks at the year and decides. If year is same, then looks at the month and decides. If the month is same, then looks at the day and decides.
decides == return.
solstheman Just a heads up for Java users who might want to use Calendar for Date checking: the test cases don't seem to cover real dates. I failed all the last four test cases using it, and passed them when I made my own Date class.
mkktbkkt The Java Calendar works fine, just keep in mind that there are Constants for the Months (ie. Calendar.JANUARY) - and these start with zero. The last test cases are using day at the end of the months, which can give you not real dates if you are setting the month of a Calendar instance to 8 and expecting it to be august (8 = Calendar.SEPTEMBER)
[deleted] By the same year does it mean the year in which the book was checked out or one year from the due date? It seems unreasonable to fine someone 10,000 hackos for being one day late, as someone else mentioned.
vatsalchanana The year in which the book was checked out. Yes it is unreasonable :P
Reikjavic Libraries have to make money somehow ;)
paulclift They've got to pay for the new years party by fining everyone 10000 hackos for a while :D
shBomberman Wonder what they can do with all them hackos..
menaraafat8111 This problem has some cheap trick that keeps 2 of the testcases failing :D It is related to the conditions u put in the if and else statements.
milesjohnson For anyone using JavaScript and the
Dateobject, be aware that months start at 0, not 1. This bit me at first.
jalaj123 What is the 14th test case? I'm getting a wrong answer in it.
ariesturkAsked to answer I don't know. See if you covered these inputs: 1) actual=10 1 2014, expected=9 12 2013 and 2) actual=4 2 2014, expected=1 5 2014
jalaj123 Thanx, I got it! :)
vidushig2 please tell why test case 10 is failing
vidushig2 int main(){ int d1; int m1; int y1; cin >> d1 >> m1 >> y1; int d2; int m2; int y2; cin >> d2 >> m2 >> y2; int fine = 0; if(y1d2 && m1==m2 &&y1==y2){ fine=15 * (d1-d2); cout<m2 && y1==y2){ fine=500 * (m1-m2); cout<
return 0;}
this is my code
ritveak The Key importance is to check the conditions when the books are returned even before the due date and hence in all those cases setting fine as 0.
public class Solution { static int libraryFine(int d1, int m1, int y1, int d2, int m2, int y2) { int[] month={31,28,31,30,31,30,31,31,30,31,30,31}; int h=0,c=0; if(y1==y2) { if(m1==m2) { if(d1<=d2) { h=0; } else{ h=15*(d1-d2); } } else if(m1<m2) { h=0; } else{ h=500*(m1-m2); } } else if(y1<y2) { h=0; } else{ h=10000; } return h; }
sungmkim80 Writing down the logic using a "physical" pen and paper worked out fine for me even though it took longer than expected. Lesson learned.
My C# solution can be found on GitHub.
Sort 407 Discussions, By:
Please Login in order to post a comment