gkeswani92 x, y, z, n = int(input()), int(input()), int(input()), int(input()) print ([[a,b,c] for a in range(0,x+1) for b in range(0,y+1) for c in range(0,z+1) if a + b + c != n ])
omalsa04 Looks good, but to avoid those repetitive input calls you could do something like:
x, y, z, n = (int(input()) for _ in range(4))gkeswani92 Thanks for the input. Will use this from now! :D
paul_schmeida Great tip! BTW is there any reason for using '_' as the dummy variable? What's wrong with using letter, for example 'i'?
gkeswani92 _ is used to signify that even though something is being returned, we don't plan to use that variable any where.
mukeshsinghbhak1 gives the following error in above code in python 2.7.13 : at 0x7f60c947e910>
codeharrier It's also an old Perl trick. If you just performed the input command without assigning the data to anything, it was still available in the $_ variable by default.
motox2 just a small suggestion ..the 4 in for loop will be n+1
AbhishekVermaIIT N is the number to compare the sum of x, y, z. The loop should actually have 4, as mentioned, for the inputs : x,y,z & n.
newmocart in py2 can be w/o int()
x,y,z,n = [input() for i in range(4)] print [[a,b,c] for a in range(x+1) for b in range(y+1) for c in range(z+1) if a+b+c != n]
bhosalekv Nice solution
nick3499 [deleted]karangandhi545 what is the reason for x+1 y+1 and many more
elli0t_4lders0n In simple words it signifies that the range is inclusive of max limit
alfredocambera Doesn't work on python3.5
akik22 [deleted]
NervousBlakedown I'm using this one line, but my compiler reads "wrong answer". Am I missing something? What else do I need to write?
NervousBlakedown Disregard, I figured it out.
kumarharsh I am a newbie to python and its not clear to me. WHY 4? And how the variable iterate from 0 to 1.
Code_Lord range(4) means range(0,4) that is 0,1,2,3 which is because we ahve to read 4 inputs Read list comprehensions for more. It is an easy way to build a list.
rahul_rowthi How is this syntax even valid. Just wondering.
Dev_prasad [deleted]
aa1992HackerRank Admin nice solution. But instead of range[0,x] you could do
print ([[a,b,c] for a in range(x+1) for b in range(y+1) for c in range(z+1) if a + b + c != n ])
ericali clever!!!
rajasekhariiith [deleted]SuperGogeta Trade three +1's for a +1 and a -1 at the right place :P
x, y, z, n = (int(raw_input())+1 for _ in range(4)) print [[a,b,c] for a in range(x) for b in range(y) for c in range(z) if a+b+c!=n-1]
zhangqunshi although this method is more simple, but it not easy to understand.
yidingyang1027 great!
usaliev I liked this method compared to other's.
james_niroo really like this solution. simple and easy to read
abedsarkil12 [deleted]
rachitajitsaria1 Hey, I have heard that int(raw_input()) is faster.
maximshen raw_input() was renamed to input() in python 3
boler [deleted]rahatchd Can you tell me how python carries out list comprehension internally? How come this generates lists in lexicographic increasing order (i.e z increases first, then y, then x)?
Ryukerg It is in lexographical order due to the nature of the loops. Spaced out it looks somewhat like
for a in range(x+1): for b in range(y+1): for c in range(z+1): if a + b + c != n: print(stuff is here)We start at [0,0,0]. Then c will increment to get to [0,0,1] When c hits [0,0,z], we get [0,1,0] as the next in the loop. This pattern continues and gives us the lexographical ordering required of the output.
BHEEMKUMAR it's very helpfull to understanding that what is actualy asking
masudraj6 Thanks for your solution, now we understand how it's word.
nick3499 [deleted]
nick3499 [deleted]
SanjayDeepu This solution is good! Utilising list comprehension to a good extreme.
trinadhkoya Not reqired to put input() for each variable .just call the input for _ in range(no of variables); see here
a , b = int (input()) for _ in range ( 2 ):
bennetryan Thanks for sharing your elegant code. I'm a newbie to Python, its great to see such beautiful code :)
jonobjornstad great code
andras_lengyel I don't like these "direct print" solutions. In my opinion the problem stated to create a list then print it, not just print something in a list. In other words in your solutions the list itself doesn't exist, can not be used later, it just collected when printed out. What do you think?
andras_lengyel OK, I found the answer! I can put list = instead of printoing out, then print the list. It wasn't clear for me three for loops output is collected in a list, so no need for any append tricks!
ignacio_ch Nice answer. As an alternative, to avoid multiple for loops you can use product:
combinations = list(product(range(x+1), range(y+1), range(z+1))) print([list(a) for a in combinations if sum(a) != n])
davidkobilnyk from itertools import product
raspletin it is not solution, as question was to form list comperhention. You just put out data to screen in right format, no list comperhetion created
pH03nYx Could someone explain to me what, exactly, this code does (like, statement-by-statement)(other than the input part I understand that I mostly mean the list comprehension)? I sort of have a basic understanding of how it works, but having some trouble wrapping my head around list comprehensions and how exactly the work. Mostly the "for a in range(0,x+1)" parts. What exactly does that do? Why is it (0,x+1)? Thanks in advance.
madaharishreddy just for curiosity, why you are using range(0,x+1) in the print function?
ldhyim568 why do you need two square brackets? Can someone explain this to me?
janu_s hello.. I tried to do as u said. But it is showing syntax error.
kumar_student101 from itertools import product
print([list(each) for each in product(range(x+1),range(y+1),range(z+1)) if sum(each)!=n])
kein_duarte2191 I'm new to python, but how come nobody seems to be using ":" after their for loops. You don't even use one for the if loops at the end.
infnity When you were using for statement inside the print statement you didn't use a colon infront of the for statement???? why was that
chefyunfei exactly what I had, expect I left the 0 implicit. Is it good practice to make the range explicit?
kumar_student101 For this program it is fine. But in real time data range may not be static.
mehdi_jafaree131 no need for 0 in range
gabobaby The problem states that it wants the output list printed in 'increasing order'. It should be more clear what this means. I initially interpreted this to mean that [1,1,0] would come before [3,0,0] because 1+1+0=2 is less than 3+0+0=3. But this is not the order that the comprehension list method would generate the list. And would likely involve some method of sorting a 3D array that many new users would not know at this point, so I'm assuming this is not what is meant. This problem is not clarified with the chosen example values of x=1, y=1, z=1, and N=2.
The problem could be addressed by just using larger example values, allowing us to infer from the example output which interpretation of 'increasing order' is intended.
scintilla What does N represent? Why should X+Y+Z not equal N? And what do the subscript i's represent? I don't understand the question.
saikiran9194HackerRank Admin @scintilla read the question properly. 0<=Xi<=X same for Yi and Zi.N is specified in the question.
jhub1 I am sooooooooooooo confused with the question holy cow.
ID10TERROR You can't just say "Read the question properly". He said he doesn't understand the syntax of the question.
This is a type of mathematic short-hand that not all of us understand. I for one don't even know what this short-hand is called or I'd look it up myself.
shashank21jHackerRank Admin Try now, I have updated the statement :)
ID10TERROR Thank you for the follow-up shashank21j, your revision to the statement has been helpful, but I still have some questions about the way the question is worded and why.
1.Why must i+j+k not be equal to N and does this mean it can be greater than N?
2.Please define "lexicographic increasing order"
I for one agree that list comprehension in python is a fairly simple subject, the crux of this problem for me however, is bridging the communication gap/understanding the essance of the problem you're asking.
Many people who use your site are self taught in coding and do not have a formal discrete mathematics background.
shashank21jHackerRank Admin i + j + k != N is just an added condition in this problem so you can use 1 if statement inside your list compehension syntax. It can be greater than N as long as i, j and k are in their respective limits.
- Lexicographic order is sorted order where 1, 1, 1 comes before 1, 1, 2 and 2, 1, 2 comes before 2, 2, 1 etc. etc.
ID10TERROR Thanks again shashank21j! :)
dng304 Shouldn't the statement include that X,Y,Z are integers that are possible maximums? It is a fairly important point no? For example dimensions of 2,2,2 given the statement as it currently is, means there is only 1 possible cube with 8 coordinates.
Where as if we said that 2 is the max integer value for X,Z,Y , we can have more than 1 possible cuboid. For example a 1,1,2 cuboid.
mike_kinny I have also difficulty understanding the question.
Tsean Can anybody make me understand this question ? I went through few comments what this question all about but still I'm not clear Please help
eric2013Asked to answer You're given 4 numbers. The first 3 correspond to the maximum dimensions of a cube. y is the maximum height, x is the maximum width, and z is the maximum depth.
You're supposed to calulate every possible set of dimensions [x,y,z], under the condition that none exceed the input values, and that x+y+z does not add up to n.
steeeenos thanks that was very helpful!
shashanksaurav41 Thanks for the explanation eric. I've just one more question that in this lexicographic order the last dimension is [1,1,1], but our N is given to be 2. Thus the sum of x+y+z becomes 3 which is greater than N. How is this condition satisfied?? Pls explain.
eric2013 The only restriction relating to N is that i + j + k != N. i+j+k>N is perfectly valid.
shashanksaurav41 Thanks for your help. Was helpful and appreciate that
sawani_soman92 Helpful explanation! Thank you
dng304 I agree that what you say is the intention of the challenge, But my problem with this challenge is that it never states that X,Y,Z are maximums.
Sample input of 2,2,2 can only be 1 cube with 8 dimensions.
I feel like the statement should be change to express what you are saying, that X,Y,Z correspond to maximum integer dimensions.
fisher6 print([[i,j,k] for i in range(x+1) for j in range(y+1) for k in range(z+1) if sum([i,j,k]) != n])
marinskiy Here is Python 3 solution from my HackerrankPractice repository:
x, y, z, n = [int(input()) for _ in range(4)] listOfAnswers = [[i, j, k] for i in range(x + 1) for j in range(y + 1) for k in range(z + 1) if i + j + k != n] print(listOfAnswers)
Feel free to ask if you have any questions :)
jsleirer I feel like I am missing the point of this exercise with my solution. Can someone please comment on how to make my code more pythonesque and utilize list comprehensions better.
X = int(raw_input()) Y = int(raw_input()) Z = int(raw_input()) N = int(raw_input()) Xi = [x for x in range(X+1)] Yi = [y for y in range(Y+1)] Zi = [z for z in range(Z+1)] results = [] for x in Xi: for y in Yi: for z in Zi: if x + y + z != N: results.append([x,y,z]) print resultsshashank21jHackerRank Admin this is fine.
Xi Yi and Zi are not much of use here. You can make your code smaller
stcrestrada cuboid = []
results = [cuboid.append([x, y, z]) for x in range(X+1) for y in range(Y+1) for z in range(Z+1) if x + y + z != N]
print(cuboid)
Less lines, more Pythonic
PRASHANTB1984 That's really great :)
Shriswissfed print ([[a,b,c] for a in range(int(input())+1) for b in range(int(input())+1) for c in range(int(input())+1) if a+b+c!=int(input())])
why does this code not work? can you explain?
vinayshashank The inputs should be captured before the for loop is executed. In this case, a new input is expected for every iteration of the for loop. Try capturing the inputs first inside some variables and use those variables here. That will work.
gkeswani92 You don't even need to have the cuboid list to be honest :)
print ([[a,b,c] for a in range(0,x+1) for b in range(0,y+1) for c in range(0,z+1) if a + b + c != n ])stcrestrada ha!, I realized that a day later. Thanks for clearing it up though gkeswani92
gowtham95india In test case 5, the given input is 3 2 3 2
Why not [0,3,0] is not in the expected outcome as the sum is not equal to N i.e. 2 ???
Not only that, but also
[[0, 3, 0], [0, 3, 1], [0, 3, 2], [0, 3, 3], [1, 3, 0], [1, 3, 1], [1, 3, 2], [1, 3, 3], [2, 3, 0], [2, 3, 1], [2, 3, 2], [2, 3, 3], [3, 3, 0], [3, 3, 1], [3, 3, 2], [3, 3, 3]
are with in the grid and sum not equal to N i.e. 2.
shashank21jHackerRank Admin Second index can go till 2, you are asking 030 it's invalid. 3,2,3 is the upper limit
kishankk x=3 y=2 z=3 n=2
y possible values can be [0,1] and thus 3 can't be there in the solution.
gowtham95india I got it. Thank you guys.
sunitachoudhary1 how you put comma in between corrdinates bracket [0,3,0],[0,3,1] this comma b/w two bracket.i tried but for me its coming after end bracket also,,so its showing error.
rajesh_narasiman Solution:
X = int (input()) Y = int (input()) Z = int (input()) N = int (input()) output=[[i,j,k] for i in range(X + 1) for j in range(Y + 1) for k in range(Z + 1) if ( i + j + k) != N ] print(output)
joneswong26 if __name__ == '__main__': x = int(input()) y = int(input()) z = int(input()) n = int(input()) lst=[] for X,Y,Z in zip(range(0,x+1),range(0,y+1),range(0,z+1)): if x+y+z!=n: a=[X,Y,Z] lst.append(a) print(lst)how to correct my code?My code will not generate result like(0,1,1).....
Sort 160 Discussions, By:
Please Login in order to post a comment