We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
THANK YOU MAN
This helped me a lot. I'm using String instead of StringBuilder or StringBuffer. Now I changed it to StringBuffer and my code ran faster than before :) This can still be reduced to:
public static void main(String[] args) {
Scanner in = new Scanner(System.in);
int t = in.nextInt();
for(int a0 = 0; a0 < t; a0++){
{
int n = in.nextInt();
StringBuilder strb=new StringBuilder();
for(int i=n;i>=0;i--)
{
if(i%3==0 && (n-i)%5==0)
{
int j=0;
for(j=0;j<i;j++)
strb.append("5");
for(int k=j;k<n;k++)
strb.append("3");
break;
}
}
if(strb.length()==0)
System.out.println("-1");
else
System.out.println(strb);
}
}
}
since your amount of 5s need to be divisible by 3 you can append "555" instead and tweak the count of your j in the loop to match, and the same for your 3s to get through the loop a little faster.
Why mix output logic with determination of x and y?
Why use loops to build string (or Stringbuilder)? Obfuscates code.
Here is my solution:-
static void decentNumber(int n)
{
int x = 0;
int y = 0;
for (int i = n; i >= 0; i--)
{
if (i % 3 == 0 && (n - i) % 5 == 0)
{
x = i;
y = n - i;
break;
}
}
var res = y == 0 && x==0? "-1" : new string('5', x) + new string('3', y);
Console.WriteLine(res);
}
Using String instead of StringBuffer results in timeout for most test cases.I found out why-
"Simply stated, objects of type String are read only and immutable. The StringBuffer class is used to represent characters that can be modified. The significant performance difference between these two classes is that StringBuffer is faster than String when performing simple concatenations."
Sherlock and The Beast
You are viewing a single comment's thread. Return to all comments →
THANK YOU MAN This helped me a lot. I'm using String instead of StringBuilder or StringBuffer. Now I changed it to StringBuffer and my code ran faster than before :) This can still be reduced to:
Can you explain the logic please?
since your amount of 5s need to be divisible by 3 you can append "555" instead and tweak the count of your j in the loop to match, and the same for your 3s to get through the loop a little faster.
thanks for the feedback, nice thinking!
nice, this help me.
Thanx man , easy to understand
Excellent solution... @Dineshchv..
Why mix output logic with determination of x and y?
Why use loops to build string (or Stringbuilder)? Obfuscates code.
Here is my solution:-
Using String instead of StringBuffer results in timeout for most test cases.I found out why- "Simply stated, objects of type String are read only and immutable. The StringBuffer class is used to represent characters that can be modified. The significant performance difference between these two classes is that StringBuffer is faster than String when performing simple concatenations."
Thanks man this help me a lot, i was confussed with that even it is not printing in eclipse also.
That string builder approach helped me too thanks for help!!