We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
Pro Tip for Java user: Use the StringBuilder class.
String is immutable, so everytime you add to a string, it creates a new object! With an input of 100000, you'd have created 30000 new objects each containing the string it was before it plus what you added to it! You can imagine how innefficient this is.
StringBuilder, 1 object, 1 problem solved. Use StringBuilder today!
(This message is brought to you by StringBuilder Co. We build Strings in a timely manner for you, so you don't have to!)
Wow, thank you for your comment. I spent like 5 hours or so messing with my code before coming here and finding this comment. I had tried finding larger strings to try to append together (e.g. adding three 5's at a time versus one 5) and that made it faster but not enough. But then you enlightened me, thank you so much.
Hey man, I didnt know how StringBuilder worked, but still got the solution reducing the number of iterations.
public static void main(String[] args) {
Scanner in = new Scanner(System.in);
int t = in.nextInt();
for (int i=0;i<t;i++){
int n = in.nextInt();
String sol3 = "", sol5 = "";
String staux = "555";
while(n>0){
if (n%3==0)
break;
else{
sol3+="33333";
n-=5;
}
}
while (n>0){
if (staux.length()<=n){
sol5+=staux;
n-=staux.length();
staux+=staux;
}
else
if (n<3)
break;
else
staux="555";
}
if (n==0)
System.out.println(sol5+sol3);
else
System.out.println(-1);
}
}
Still much better using Stringbuilder, but not impossible with strings ;) Thanks for the info.
Same for C#. I just wasted 1 hour by doing string concatenations and getting timeouts. Honestly man, even after learning string theory a dozen times, I still forget that strings are immutable.
Sherlock and The Beast
You are viewing a single comment's thread. Return to all comments →
Pro Tip for Java user: Use the StringBuilder class.
String is immutable, so everytime you add to a string, it creates a new object! With an input of 100000, you'd have created 30000 new objects each containing the string it was before it plus what you added to it! You can imagine how innefficient this is.
StringBuilder, 1 object, 1 problem solved. Use StringBuilder today!
(This message is brought to you by StringBuilder Co. We build Strings in a timely manner for you, so you don't have to!)
Thanks man. Now all the test cases are accepted.
Wow... didn't know how powerful StringBuilder is. Thank you!
ok you are the best
MVP :')
Thanks!!
Wow, thank you for your comment. I spent like 5 hours or so messing with my code before coming here and finding this comment. I had tried finding larger strings to try to append together (e.g. adding three 5's at a time versus one 5) and that made it faster but not enough. But then you enlightened me, thank you so much.
That was very helpful! But I didnot use StringBuilder. I printed the numbers inside loop and printed a new line after the loop.
Solved my timeout problem. Thank you!
Thanks a lot, solved my timeout issue! Here is a virtual cookie for you! :D
Cookie cookie = new Cookie("thanks","please have this cookie"); HttpServletResponse tummy = new HttpServletResponse(); tummy.add(cookie);StringBuilder saved my marriage and helped my kids get through college. Thank you StringBuilder!
Thanks.My test cases are now accepted.
String appending indeed is a problem, string builder is so much better, thanks for your tip!
Hey man, I didnt know how StringBuilder worked, but still got the solution reducing the number of iterations.
Still much better using Stringbuilder, but not impossible with strings ;) Thanks for the info.
Same tip for the C# crowd. Strings are immutable; go with the StringBuilder
hahah nice ad..
Same for C#. I just wasted 1 hour by doing string concatenations and getting timeouts. Honestly man, even after learning string theory a dozen times, I still forget that strings are immutable.
Thanks man.