We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
  1. Practice
  2. Data Structures
  3. Linked Lists
  4. Insert a Node at the Tail of a Linked List
  5. Discussions

Insert a Node at the Tail of a Linked List

  • AnuragPatil + 9 comments

    Please suggest , unable to find out mistake in this :

    Node* Insert(Node *head,int data)
{
Node *temp;
temp->data = data;
temp->next = NULL;

if(head == NULL)
  {
  head = temp;
}
else
  {
  Node *p;
  p = head;
  while(p->next != NULL)
      p = p->next;
  p->next = temp;
}
return(head);
}

    Showing no response in output :(

    • rajinder0852 + 1 comment

      you do not assign the address to pointer temp Node* Insert(Node *head,int data) { Node *temp; temp=new Node(); //That's the statement missing temp->data = data; temp->next = NULL;

      if(head == NULL) { head = temp; } else { Node *p; p = head; while(p->next != NULL) p = p->next; p->next = temp; } return(head); }

      • prannavk1 + 1 comment
        p->next=temp; 

//in cpp , giving a segmentation fault

        why is the above code giving me segmentation fault

        • desnesn + 0 comments

          When you exit the while loop you have a pointer pointing to nowhere. It didn't matter on the Print exercise, but here it does.

          In your else statement, create another Node* pointer variable (*tail, for instance), and make it receive your *p at each iteration.

          At the last iteration, it will be pointing to the last Node structure, which will be the tail of the linked list. Then your p->next=temp; will work :-) !

    • varuos_oohas + 4 comments
      Node* Insert(Node *head,int data)
{
Node *temp=new Node();
temp->data = data;
temp->next = NULL;

if(head == NULL)
  {
  head = temp;
}
else
  {
  Node *p;
  p = head;
  while(p->next != NULL)
      p = p->next;
  p->next = temp;
}
return(head);
}
      • prannavk1 + 2 comments
        p->next=temp; 

//in cpp , giving a segmentation fault

        why is the above code giving me segmentation fault

        • KuboK + 0 comments

          pointer temp needs to have assigned an adress

          Node *temp=new Node();
        • Sahilamin219 + 0 comments

          try making p->next=temp statement out side of the while loop . it should not affect the result anyway.

      • chattyhack + 0 comments

        nice code

      • abbhishek971 + 7 comments

        This is my solution in C++14

        Node* Insert(Node *head,int data)
{
    Node *temp = new Node();
    temp->data = data;
    temp->next = NULL;
   if(head==NULL)
   {
       head = temp;
   }
   else if(head->next==NULL)
   {
            head->next = temp;
            return head;
    }
    else
    {
        Insert(head->next,data);
    }
    return head;
}
        • arkaguin + 0 comments

          thanks

        • neeraj1515_kaus1 + 1 comment

          what is the difference bet Node* temp and Node *temp.?

          • abbhishek971 + 0 comments

            Apologies for the delay in reply.

            There's no difference. Both the notations result in the same identifier declaration.

        • raghuvendra867 + 0 comments

          bro can u explain ur code?

        • abhishekjoshi261 + 0 comments

          solution.cc:46:1: error: ‘Node’ does not name a type; did you mean ‘modf’? Node* Insert(Node head,int data) ^~~~ modf solution.cc: In function ‘int main()’: solution.cc:83:41: error: ‘insertNodeAtTail’ was not declared in this scope SinglyLinkedListNode llist_head = insertNodeAtTail(llist->head, llist_item);

                  showing this error code not working
        • shubhvratj + 6 comments

          SinglyLinkedListNode* insertNodeAtTail(SinglyLinkedListNode* head, int data) {

              SinglyLinkedListNode *new_node,*ptr;
    new_node = new SinglyLinkedListNode();
    new_node->data = data;
    new_node->next = NULL;
    if(head == NULL){
        head = new_node;
        return head;
    }else{
        ptr = head;
        while(ptr != NULL){
            ptr = ptr->next;
        }
        ptr->next = new_node;
        new_node->next = NULL;
return head;    
    }

          }

          can you please help me with this code?

          • abhishekjoshi261 + 0 comments

            Node* Insert(Node *head,int data) { struct Node *temp,*tail,*ptr; temp=new Node; temp->data=data; temp->next=NULL; if(head==NULL) { head=temp;} else { ptr=head; while(ptr!=NULL) { tail=ptr; ptr=ptr->next; } tail->next=temp; } return head;

            }

            bro i think you missed the struct function and above is the soln that worked for me pm me if you find any problem

          • asmitaverma + 0 comments
            [deleted]
          • asmitaverma + 2 comments

            Here's my solution in C++14. The class definition of SinglyLinkedListNode specifies that the constructor has an argument which is the data part of the node to be inserted.

            SinglyLinkedListNode* insertNodeAtTail(SinglyLinkedListNode* head, int num){

            SinglyLinkedListNode* node = new SinglyLinkedListNode(num);
node->data = num;
node->next = NULL;

if(head == NULL){
    head = node;
}

else{
    SinglyLinkedListNode* temp;
    temp = head;
    while(temp->next != NULL){
        temp = temp->next;
    }
    temp->next = node;
}

return head;

            }

            • anamalaii + 0 comments

              Thank you

            • alexey_chekhovi1 + 0 comments

              SinglyLinkedListNode* node = new SinglyLinkedListNode(num);

              Works.

              SinglyLinkedListNode *newNode = new SinglyLinkedListNode();

              solution.cc:61:62: error: no matching function for call to ‘SinglyLinkedListNode::SinglyLinkedListNode()

              So we do not have an empty constructor, but do have a constructor with parameters. The one who wrote the background of this task should be immediately exterminated.

          • akkidewangan96 + 0 comments

            new_node = new SinglyLinkedListNode(data);

            try this in 2nd line

          • sanket_sonje99 + 0 comments
            [deleted]
          • sanket_sonje99 + 0 comments

            SinglyLinkedListNode *new_node = new SinglyLinkedListNode(data); new_node->data = data; new_node->next = NULL;

            SinglyLinkedListNode *ptr;

if(head == NULL)
{
    head = new_node;
    return head;
}
else
{
    ptr = head;
    while(ptr->next != NULL)
    {
        ptr = ptr->next;
    }
    ptr->next = new_node;
    new_node->next = NULL;

    return head;    
}
        • akkuarora07 + 0 comments

          how can i remove this error?

          solution.cc:47:1: error: ‘Node’ does not name a type; did you mean ‘modf’?

          please help.

        • ashish21ghosh + 0 comments

          I don't think you need to check if head->next==NULL, rather in the else block you can add

          head->next = Insert(head->next,data);

      • satish_ucer + 0 comments

        Node *temp=new Node(); is not working in my code. can you explain it?

    • jackie88812 + 0 comments

      you need memory space before temp->data = data;

      It's my suggestion below: Node *temp = (Node *)malloc(sizeof(Node)); temp->data = data; temp->NULL;

    • Vneel + 0 comments

      the statement p->next=temp; needs to be out of the while loop. You assign after you traverse the whole list, not at every node.

    • kartikaythakkar + 1 comment

      Node* Insert(Node *head,int data) { Node *temp=new Node(); temp->data=data; temp->next=NULL; if(head==NULL){ head=temp; } else{ Node *p; p=head; while(p->next !=NULL){ p=p->next; } p->next=temp; } return head; }

      • arkaguin + 0 comments

        thanks

    • gkartik640 + 0 comments

      same as mine. did u resolve it.

    • praveen_dakshan1 + 0 comments

      in your while loop , it should not be there(p->next=temp).

    • dark_c_03 + 0 comments

      you have to create new node and allocate memory to it by malloc or new in c++

    • vnaykanswal55 + 0 comments

      Do dynamic memory allocation C++ Node* temp=new Node(); C Node* temp= (Node*)malloc(sizeof(Node));