We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
you do not assign the address to pointer temp
Node* Insert(Node *head,int data)
{
Node *temp;
temp=new Node(); //That's the statement missing
temp->data = data;
temp->next = NULL;
if(head == NULL)
{
head = temp;
}
else
{
Node *p;
p = head;
while(p->next != NULL)
p = p->next;
p->next = temp;
}
return(head);
}
When you exit the while loop you have a pointer pointing to nowhere. It didn't matter on the Print exercise, but here it does.
In your else statement, create another Node* pointer variable (*tail, for instance), and make it receive your *p at each iteration.
At the last iteration, it will be pointing to the last Node structure, which will be the tail of the linked list. Then your p->next=temp; will work :-) !
solution.cc:46:1: error: ‘Node’ does not name a type; did you mean ‘modf’?
Node* Insert(Node head,int data)
^~~~
modf
solution.cc: In function ‘int main()’:
solution.cc:83:41: error: ‘insertNodeAtTail’ was not declared in this scope
SinglyLinkedListNode llist_head = insertNodeAtTail(llist->head, llist_item);
Here's my solution in C++14. The class definition of SinglyLinkedListNode specifies that the constructor has an argument which is the data part of the node to be inserted.
SinglyLinkedListNode* insertNodeAtTail(SinglyLinkedListNode* head, int num){
SinglyLinkedListNode* node = new SinglyLinkedListNode(num);
Works.
SinglyLinkedListNode *newNode = new SinglyLinkedListNode();
solution.cc:61:62: error: no matching function for call to ‘SinglyLinkedListNode::SinglyLinkedListNode()
So we do not have an empty constructor, but do have a constructor with parameters. The one who wrote the background of this task should be immediately exterminated.
Insert a Node at the Tail of a Linked List
You are viewing a single comment's thread. Return to all comments →
Please suggest , unable to find out mistake in this :
Showing no response in output :(
you do not assign the address to pointer temp Node* Insert(Node *head,int data) { Node *temp; temp=new Node(); //That's the statement missing temp->data = data; temp->next = NULL;
if(head == NULL) { head = temp; } else { Node *p; p = head; while(p->next != NULL) p = p->next; p->next = temp; } return(head); }
why is the above code giving me segmentation fault
When you exit the while loop you have a pointer pointing to nowhere. It didn't matter on the Print exercise, but here it does.
In your else statement, create another Node* pointer variable (*tail, for instance), and make it receive your *p at each iteration.
At the last iteration, it will be pointing to the last Node structure, which will be the tail of the linked list. Then your
p->next=temp;will work :-) !why is the above code giving me segmentation fault
pointer temp needs to have assigned an adress
nice code
This is my solution in C++14
thanks
what is the difference bet Node* temp and Node *temp.?
Apologies for the delay in reply.
There's no difference. Both the notations result in the same identifier declaration.
bro can u explain ur code?
solution.cc:46:1: error: ‘Node’ does not name a type; did you mean ‘modf’? Node* Insert(Node head,int data) ^~~~ modf solution.cc: In function ‘int main()’: solution.cc:83:41: error: ‘insertNodeAtTail’ was not declared in this scope SinglyLinkedListNode llist_head = insertNodeAtTail(llist->head, llist_item);
SinglyLinkedListNode* insertNodeAtTail(SinglyLinkedListNode* head, int data) {
}
can you please help me with this code?
Node* Insert(Node *head,int data) { struct Node *temp,*tail,*ptr; temp=new Node; temp->data=data; temp->next=NULL; if(head==NULL) { head=temp;} else { ptr=head; while(ptr!=NULL) { tail=ptr; ptr=ptr->next; } tail->next=temp; } return head;
}
bro i think you missed the struct function and above is the soln that worked for me pm me if you find any problem
Here's my solution in C++14. The class definition of SinglyLinkedListNode specifies that the constructor has an argument which is the data part of the node to be inserted.
SinglyLinkedListNode* insertNodeAtTail(SinglyLinkedListNode* head, int num){
}
Thank you
Works.
So we do not have an empty constructor, but do have a constructor with parameters. The one who wrote the background of this task should be immediately exterminated.
new_node = new SinglyLinkedListNode(data);
try this in 2nd line
how can i remove this error?
solution.cc:47:1: error: ‘Node’ does not name a type; did you mean ‘modf’?
please help.
Node *temp=new Node(); is not working in my code. can you explain it?
you need memory space before temp->data = data;
It's my suggestion below: Node *temp = (Node *)malloc(sizeof(Node)); temp->data = data; temp->NULL;
the statement p->next=temp; needs to be out of the while loop. You assign after you traverse the whole list, not at every node.
Node* Insert(Node *head,int data) { Node *temp=new Node(); temp->data=data; temp->next=NULL; if(head==NULL){ head=temp; } else{ Node *p; p=head; while(p->next !=NULL){ p=p->next; } p->next=temp; } return head; }
thanks
same as mine. did u resolve it.
in your while loop , it should not be there(p->next=temp).
you have to create new node and allocate memory to it by malloc or new in c++