We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
Loading...
  1. Practice
  2. Data Structures
  3. Linked Lists
  4. Insert a Node at the Tail of a Linked List
  5. Discussions

Insert a Node at the Tail of a Linked List

  • samfelder17 + 5 comments

    I tried doing mine recursively in C any idea what went wrong?

    Node* Insert(Node *head,int data)
{
    if(head->next==NULL)
        {
            Node *newn=(Node *)malloc(sizeof(Node));
            head->next=newn;
            newn->next=NULL;
            newn->data=data;
            return newn;
        }
    Insert(head->next,data);
    return head;
}
    • bsiddarth29 + 1 comment

      According to the problem statement... 1.)You need to figure out a way if head=NULL i.e if the list is empty but when you declare "if(head->next==NULL)" it means that you are consider only the non empty case. 2.)Even in this above case you are just returning "newn" nut you need to return thr address of first node which is "head"!

      try adding if(head==NULL) block of statements also

      • pandeysatyendra1 + 0 comments

        ya bro u r right this is needed in this code....

    • vishal_gupta1_c1 + 0 comments

      You are making changes in head only, which is wrong. Take any other pointer & copy head into it & then proceed,rest your code seems absolutely fine.

    • kalpitshah0078 + 1 comment

      you have not covered the condition where the head is null. if you want to do this in this manner , your code should be somthing like this:

      Node* Insert(Node *head,int data) { if(head==NULL) { Node *newn=(Node *)malloc(sizeof(Node));

              newn->next=NULL;
        newn->data=data;
        head=newn;

    }
else{
     Node *newn2=(Node *)malloc(sizeof(Node));
    newn2=head;
    while(newn2->next!=NULL){
        newn2=newn2->next;
    }
    newn2->next=Insert(newn2->next , data);

}
return head;

      }

      • saikiranhs + 0 comments

        thanks! nice one! you can reduce complexity by removing while loop there, because anyway in recursion head moves as you pass newn2->next, so no need to check the condition whether it is pointing to the extreme

    • avik_dutta111191 + 0 comments

      Only problem with recursive one is how to return the start pointer of the list ...(i tried it tooo)

    • pandeysatyendra1 + 0 comments

      actually you are not using concept if head is already null then what will print.......