We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
Loading...
  1. Practice
  2. Algorithms
  3. Warmup
  4. Plus Minus
  5. Discussions

Plus Minus

  • joelvarma + 2 comments

    three print statements with for loop, you are linearly searching 3 times the array which increases the complexity right? what special in this code other than reducing LOC

    • ricky03cool + 0 comments

      updated

    • SebastianNielsen + 2 comments

      There is nothing special about it, the code is not very efficient. - looking at the prettiness of the code, I would say it's around decent - pretty. It's very readable, and understandable. Compared to this s*** for instance: (I didn't write it)

      print("{:6f}\n{:6f}\n{:6f}".format(len(list(filter(lambda x:x>0,arr)))/len(arr),len(list(filter(lambda x:x<0 , arr)))/len(arr),len(list(filter(lambda x:x==0,arr)))/len(arr)))

      This was my solution:

      n = int(input())
arr = [int(x) for x in input().split()]

positive = 0
negative = 0
zeroes = 0

for i in arr:
    if i > 0:
        positive += 1
    elif i < 0:
        negative += 1
    else:
        zeroes += 1

Length = len(arr)
print(positive/Length)
print(negative/Length)
print(zeroes/Length)

      the best possible performance, and it's easy to read, and just looks overall pretty.

      • Ardillo + 1 comment

        the first code is not only ugly but innefficient. Yout code is simple yes, good performance but it is 0 pythonic and you have two variables with the same value (n and Length). It is not bad but if you are using python you should make use of their tricks. Efficient is wrost in my solution for small inputs.

        Check mine:

        n = int(input())
arr = [0 if i is 0 else i/abs(i) for i in map(int, input().split())]

for num in map(arr.count, [1, -1, 0]):
    print(round(num/n, 6))

        Both have the same performance and both are clear but in mine you are not using excessive code for a simple things.

        Anyways a variation of yours with your logic can be:

        n = int(input())
values = {'zeros': 0, 'negative': 0, 'positive': 0}

for i in map(int, input().split()):
    values['positive'*(not i) + 'negative'*(i<0) + 'zeros'*(i>0)] += 1

print('\n'.join(map(lambda x: str(round(x/n, 6)) ,values.values())))

        In this case is clean and almost more efficient than your solution for small inputs (as map and join presents better performance than a list comprehension and a triple print)

        • SebastianNielsen + 1 comment

          Wow, well said. I love how you coded this:

          for i in map(int, input().split()):
    values['positive'*(not i) + 'negative'*(i<0) + 'zeros'*(i>0)] += 1

          Edit: it seems like you made a mistake, if 'i>0' zeroes will increase with 1. if i=0 positive will increase with 1

          You need to swap the statements 'not i' and 'i>0'

          • Ardillo + 0 comments

            Yes! sorry for the mistake ^^"

      • toaa_kama2354 + 1 comment

        My code is almost same as yours but my code does not pass case 2,4,5,6. Can you tell what might be wrong?

        import sys

def plusMinus(arr):
    # Complete this function
    pos=0
    neg=0
    zero=0
    for i in arr:
        if i>0:
            pos+=1
            result=float(pos/n)
        elif i<0:
            neg+=1
            num=float(neg/n)
        else:
            zero+=1
            count=float(zero/n)
            
    print("%.6f" % result)
    print("%.6f" % num)
    print("%.6f" % count)
        • philmiller1992 + 0 comments

          You need to add n to the plusMinus function like so: def plusMinus(n, arr): # Complet this function # print("#.6f" % result) etc...