We use cookies to ensure you have the best browsing experience on our website. Please read our cookie policy for more information about how we use cookies.
Nice solution. I am writing in C#, myself. I def. had to start with a more fleshed-out solution and work my way down to this. I wonder if a lengthier solution would be more communicative of the imposed requirements. I pushed mine up as a one-liner, though.
Thanks. A lengthier solution might improve readability but compromise on lines of code (maintainability). Either way it doesn't affect runtime, so it comes down to a matter of personal preference I guess. :)
I don't agree that a lengthier answer would compromise maintainability. If you deal with a smaller chunk of code, it's easier to maintain as you can focus on a narrow logic.
Probably not in this question but I pointed that out in general from an interview/development perspective. For this particular qs, it's only a matter of preference.
staticint[]solve(int[]grades){// Complete this functionfor(inti=0;i<grades.length;i++){if(grades[i]>=38){if(grades[i]+(5-grades[i]%5)-grades[i]<3)grades[i]=(grades[i]+(5-grades[i]%5));}}returngrades;}
Your solution is perfectly fine but as a first draft. Whenever possible take out common operations and put it in a variable so next time what if the moderator said that multiple of 6 instead of 5 . you'll have to change at 2 places in your case but it may be a become bigger issue in complex chunk. Just saying. :)
(5 - grades[i] % 5) < 3 if this is the condition you are talking about then the question says that If the difference between the grade and the next multiple of 5 is less than 2.
Would this be better? For reability only. Im not sure. It's really the same solution.
int[] res = new int[grades.Length];
for (int i = 0; i < grades.Length; i++)
{
int current = grade[i];
if (grades[i] % 5 > 2 && !(grades[i] < 38))
current = grades[i] + (5-grades[i]%5);
res[i] = current;
}
return res;
according to me it shouldn't work but if it passed test cases ,then i dont know how .the reason is that consider a number like 73 ,then n%5 should give 3 ,and hence it would redirect to the else statement and print n, whereas it should have printed 75 as we need to consider the next multiple of 5 ,75-73 =2 (<3) .Correct me ,if i am wrong ,anyone. (might be i am wrong too :P ,i developed my solution in my way ,though!)
73 % 5 = 3 and 3 <= 3, so it'll satisfy the else if condition.
Then we have cout << 73 + (5- 73%5) << endl; which simplifies to cout << 73 + 2 << endl;
Grading Students
You are viewing a single comment's thread. Return to all comments →
Nice solution. I am writing in C#, myself. I def. had to start with a more fleshed-out solution and work my way down to this. I wonder if a lengthier solution would be more communicative of the imposed requirements. I pushed mine up as a one-liner, though.
Thanks. A lengthier solution might improve readability but compromise on lines of code (maintainability). Either way it doesn't affect runtime, so it comes down to a matter of personal preference I guess. :)
I don't agree that a lengthier answer would compromise maintainability. If you deal with a smaller chunk of code, it's easier to maintain as you can focus on a narrow logic.
Probably not in this question but I pointed that out in general from an interview/development perspective. For this particular qs, it's only a matter of preference.
It's a terrible solution. Hello? Have you ever heard of the words, "RE-READ YOUR WORK?" Oh, and plus, it doesn't work. :)
It works perfectly fine.
https://www.hackerrank.com/challenges/grading/submissions/code/39368045
In case of issues, let me know.
I have another solution for the same.
I did this with backward iteration and without your most inner If:
What's the point of the backwards iteration? It practically won't make any difference.
Yes it will! it will make the array go back wards and solution will be saved and appear in LIFO.
It is a stack implementation.
in your solution what happen if grade[i] = 67 them grades[i] % 5 = 7 and them 5-7 = -2 so 67 -2 = 65
No, it will not pass the second condition of the if statement. Because 67 % 5 = 2 not 7.
As @keickhoff1 pointed out 67 remains 67.
Your solution is perfectly fine but as a first draft. Whenever possible take out common operations and put it in a variable so next time what if the moderator said that multiple of 6 instead of 5 . you'll have to change at 2 places in your case but it may be a become bigger issue in complex chunk. Just saying. :)
very good, by the way it has to be grades.Length
in the inner if() , why did you do a grades[i] + blahBlahPivot - grades[i]? i mean, grades[i]-grades[i] is zero anyway so why bother?
this program have some error check your program
Your answer is nice.But why you put -grades[i]<3 in if condition can you explain it.
(5 - grades[i] % 5) < 3 if this is the condition you are talking about then the question says that If the difference between the grade and the next multiple of 5 is less than 2.
Your link doesn't work, like the code provided above
my solution
Would this be better? For reability only. Im not sure. It's really the same solution.
int[] res = new int[grades.Length];
You are right. There is a pretty big epedimic of poor readability in coding these days. Some of these projects are pretty good proof of that.
A simple and perhaps readable solution.. You can use n instead of temp as its just a dummy..
Why use EOF?
it stands for end of file
what is the use of temp?
to satisfy the input condition.
according to me it shouldn't work but if it passed test cases ,then i dont know how .the reason is that consider a number like 73 ,then n%5 should give 3 ,and hence it would redirect to the else statement and print n, whereas it should have printed 75 as we need to consider the next multiple of 5 ,75-73 =2 (<3) .Correct me ,if i am wrong ,anyone. (might be i am wrong too :P ,i developed my solution in my way ,though!)
73 % 5 = 3 and 3 <= 3, so it'll satisfy the else if condition. Then we have cout << 73 + (5- 73%5) << endl; which simplifies to cout << 73 + 2 << endl;
Why are we checking <=3 and not some other number?
wow ..thank u
EOF?
It is a achronym of null(0) in C language in stdio.h
You can do the same thing in C# ->
return grades.Select(grade => grade < 38 || (grade % 5 < 3) ? grade : grade + (5 - grade % 5 )).ToArray();
Excellent
Can you please also tell me that ToArray is to be used only when we are returning an array?
grade < 38 || grade : grade % 5))); } return $g;
php code
Don't know why I got downvoted for a simple comment?